Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error messages on ErgoTree evaluation #720

Merged
merged 74 commits into from
Sep 27, 2023
Merged

Better error messages on ErgoTree evaluation #720

merged 74 commits into from
Sep 27, 2023

Conversation

greenhat
Copy link
Member

@greenhat greenhat commented Jul 18, 2023 •
edited
Loading

Close #353

@coveralls
Copy link

coveralls commented Jul 18, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6324467950

  • 705 of 1132 (62.28%) changed or added relevant lines in 90 files are covered.
  • 14 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.9%) to 81.06%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ergo-lib/src/chain/transaction/reduced.rs 4 5 80.0%
ergotree-interpreter/src/eval/create_prove_dh_tuple.rs 0 1 0.0%
ergotree-interpreter/src/eval/create_provedlog.rs 0 1 0.0%
ergotree-interpreter/src/eval/decode_point.rs 1 2 50.0%
ergotree-interpreter/src/eval/deserialize_register.rs 5 6 83.33%
ergotree-interpreter/src/eval/expr.rs 19 20 95.0%
ergotree-interpreter/src/eval/extract_reg_as.rs 1 2 50.0%
ergotree-ir/src/chain/ergo_box/register/id.rs 3 4 75.0%
ergotree-ir/src/type_check.rs 0 1 0.0%
ergotree-interpreter/src/eval/sbox.rs 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
ergotree-ir/src/mir/expr.rs 2 82.23%
ergotree-interpreter/src/eval/env.rs 3 66.67%
ergotree-ir/src/serialization/types.rs 4 84.67%
ergotree-ir/src/chain/token.rs 5 72.58%
Totals Coverage Status
Change from base Build 6248584962: -1.9%
Covered Lines: 10511
Relevant Lines: 12967
💛 - Coveralls

@greenhat greenhat force-pushed the i353-eval-error-trace branch 2 times, most recently from 6c7e963 to a2b4774 Compare July 24, 2023 10:45
@greenhat greenhat force-pushed the i353-eval-error-trace branch from 31a3da2 to f851f47 Compare August 11, 2023 09:53
@greenhat greenhat force-pushed the i353-eval-error-trace branch from 0bbd093 to 0642ba0 Compare September 4, 2023 12:35
@greenhat
make Evaluable::eval's environment a mutable ref;
2428e3e
@greenhat
add EvalError::WrappedWithEnvError with evaluation env attached;
0e819e9
@greenhat
draft SourceSpan and SourceSpanWrapper;
65b129d
@greenhat
enrich Append eval error with source span;
35dd5ac
@greenhat
Move source_span module to the ergotree-ir crate root;
a96a7c9 
rename SourceSpan to Span and wrapper to Spanned;
@greenhat
draft pretty printer types and smoke test;
eda5e27
@greenhat
draft Print trait IR nodes;
8b3d624
@greenhat
draft Printer trait tracking current position and indentation level;
7a562f7
@greenhat
draft Print impl for Expr;
7f28707
@greenhat
draft the expr printing and running eval again in reduce_to_crypto;
868076b
@greenhat
extract EvalError into a separate module;
e46c92e
@greenhat
merge wrapped EvalError variants into one;
e20f087
@greenhat
extract EvalErrorDetails and add wrap_with_src for EvalError;
01cb82f
@greenhat
impl Print for BlockValue;
c99f6ce
@greenhat
formatting;
c10d084
@greenhat
impl Print for ValDef and Constant;
0eb274b
@greenhat
impl Print for ValUse, fix indentations and new lines in pretty printer;
8bb1181
@greenhat
Rename Span to SourceSpan and switch it to offset+length based repres…
c6b94db 
…entation;
@greenhat
impl Print for BinOp;
be311ac
@greenhat
fix nested error wrapping, add division by zero eval test;
a948266
@greenhat
fix spanned Expr construction in Print implementations;
d353c71
@greenhat
rework wrapped EvalError variants, add custom Display impl for wrappe…
e320143 
…d variants;
@greenhat
add source span test eval error;
bf365dd
@greenhat
impl Print for GlobalVars;
9f8dfea
@greenhat
impl pretty printing for ByIndex and add out of bounds error test;
e26d18e
@greenhat
wrap TreeLookup in Spanned;
986fc41
@greenhat
fix expected formatting in pretty printer tests;
1e282b6
@greenhat
fix formatting;
9eb85a1
@greenhat
update expected source spans in binop pretty print test;
6bb6761
@greenhat
skip ConstPlaceholder in pretty printer;
91e2a0f
@greenhat
fix source span in expected pretty printer test;
5b3873b
@greenhat
move Print trait and implementations into a separate module;
824ed24
@greenhat
add EIP23 refresh contract as pretty printer test;
40301df 
Implement Print for various IR nodes;
@greenhat
add Print impl for various IR nodes and print EIP23 refresh contract;
ec07000
@greenhat
add EIP23 update contract as pretty printer test;
b55a0b3
@greenhat
add EIP23 ballot contract as pretty printer test;
aa23f31
@greenhat
add EIP23 oracle contract as pretty printer test;
1456b1d
@greenhat
add ageusd bank contract to pretty printer test
b81978c
@greenhat
add ageusd update contract to pretty printer test;
91c3cf4
@greenhat
add eip14 amm pool and swap contracts to pretty printer tests;
b1e4091
@greenhat
add the rest of amm_conc_pool_* EIP22 auction contracts to the pretty…
4d09d26 
… printer tests;
@greenhat
add doc comment;
d1b0e56
@greenhat
pretty printer for ByteArrayTo* IR nodes;
0eefaef
@greenhat
impl Print for LongToByteArray and CalcSha256;
7c99195
@greenhat
implmennt pretty printing for And, Or, LogicalNot, Xor, SubstConstant…
1f7a246 
…s, Atleast;
@greenhat greenhat force-pushed the i353-eval-error-trace branch from f5ca092 to 1f7a246 Compare September 22, 2023 10:22
@greenhat greenhat marked this pull request as ready for review September 27, 2023 10:08
@greenhat greenhat merged commit 9ab86db into develop Sep 27, 2023
12 checks passed
@greenhat greenhat deleted the i353-eval-error-trace branch September 27, 2023 13:05
@greenhat greenhat mentioned this pull request Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better ErgoTree evaluation error messages
2 participants
@greenhat @coveralls